-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support latest with filter on local and global #633
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
537472c
Move command that returns the latest version to a utility function
klane 9c82d11
Add support for filtering installed versions with asdf list
klane e1331cd
Add support for using the latest installed version of a tool
klane c1bcade
Add tests for new features
klane 7291d97
Update documentation with new features
klane 5a084b2
Fix shellcheck errors
klane ad53811
Add error messages when filtering yields no compatible versions
klane 8f5fb89
Remove unnecessary echo flags
klane 23575a2
Rearrange asdf list error messages to retain original behavior
klane 163aca7
Improve version filtering error messages and exit codes
klane 1bb167d
Add tests for version filtering error messages
klane be68403
Rename variable to account for previous name change
klane b787fe8
Move changes to latest version in CHANGELOG
klane 00bcb8b
Replace sed with awk to get the latest version of a tool
klane 81c96e7
Merge branch 'master' into use-latest
jthegedus b2333e9
Merge branch 'master' into use-latest
jthegedus c7272f0
chore: rm changelog changes
jthegedus 73f9c58
chore: replace echo with printf
jthegedus 5c4cda6
fix: error when latest cmd with invlid version
jthegedus 6754115
chore: revert command-latest
jthegedus 4e849c7
chore: revert command-latest
jthegedus 495b1d0
fix: local & global with latest and filters
jthegedus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
check_if_version_exists
handles theref:<ref>
&path:<dir>
filters two calls deeper in the stack. Those I feel should be elevated to this level aslatest:<filter>
is handled here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not suggestion we do this now, but this codebase is becoming spaghetti as everything gets pushed down into
utils.bash