Add concurrency headers #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, DeleteObject and DeleteRelation.
Pull Request Test Coverage Report for Build 7625492122
💛 - Coveralls |
BogdanIrimie
commented
Jan 22, 2024
pkg/directory/v3/writer.go
Outdated
| @@ -46,6 +48,12 @@ func (s *Writer) SetObject(ctx context.Context, req *dsw3.SetObjectRequest) (*ds | |||
| return err | |||
| } | |||
|
|
|||
| ifMatchHeader := metautils.ExtractIncoming(ctx).Get(headers.IfMatch) | |||
| // if the updReq.Etag == "" this means the this is an insert | |||
| if ifMatchHeader != "" && updReq.Etag != "" && ifMatchHeader != updReq.Etag { | |||
There was a problem hiding this comment.
The condition detects inserts because otherwise those would always be rejected with a HashMissmatch error.
BogdanIrimie
commented
Jan 22, 2024
pkg/directory/v3/writer.go
Outdated
Comment on lines
89
to
90
| obj := &dsc3.Object{Type: req.ObjectType, Id: req.ObjectId} | ||
| updReq, err := bdb.UpdateMetadata(ctx, tx, bdb.ObjectsPath, ds.Object(obj).Key(), obj) |
There was a problem hiding this comment.
We do a DB call only if If-Match header is specified.
BogdanIrimie
requested review from
ronenh,
florindragos,
gertd,
carabasdaniel and
oanatmaria
ronenh
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
IfMatchheader check to SetObject, SetRelation, DeleteObject, DeleteRelation, and DeleteManifest.Add
IfNotmatchheader check to GetObject and GetRelatioThe headers are used for optimist concurrency.
In the case of
IfMatchHTTP 412 - Precondition Failed is returned if the IfMatch header value does not match the etagIn the case of
IfNotMatchHTTP 304-Not Modified is returned if the IfNotMatch header values do match the etagresolves https://github.com/aserto-dev/workspace/issues/527