Use aws_s3_object instead of aws_s3_bucket_object

[gjclark]

Closes #801

[reweeden]

I wonder if it would be a good idea to add a required_providers block to the terraform module so we can pin the minimum supported version of the AWS provider. I'm actually a little surprised that it works without that.

[gjclark]

I wonder if it would be a good idea to add a required_providers block to the terraform module so we can pin the minimum supported version of the AWS provider. I'm actually a little surprised that it works without that.

NISAR has:

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 5.0"
    }
    null = {
      source  = "hashicorp/null"
      version = "~> 2.1"
    }
  }
}

Should I just duplicate that here?

Well, actually, I cut out a couple things that were in https://github.com/asfadmin/CIRRUS-NISAR/blob/master/workflows/nisar/provider.tf.

[reweeden]

You should only include the providers that the module actually needs and you should use >= as explained on the best practices section here: https://developer.hashicorp.com/terraform/language/providers/requirements#best-practices-for-provider-versions

[reweeden]

Lol, why was that in there?

[gjclark]

Hah I don't know. I was hoping to find some discussion in the PR that brought that in. Couldn't find the reason.

[reweeden]

Missing newline

[reweeden]

This isn't the minimum. I just checked a random 4.x version and 4.63 has the aws_s3_object already. So you can go down at least to that.

You should find the lowest version that has that resource. I would do it through trial and error using this page and selecting the version from the version dropdown:
https://registry.terraform.io/providers/hashicorp/aws/4.63.0/docs/resources/s3_bucket_object

[gjclark]

Looks like 4.0 introduced it.