improvement: properly honor ecto type init callback

ash-project · Oct 17, 2023 · 5d85c5b · 5d85c5b
1 parent d9bacc1
commit 5d85c5b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/ash/type/datetime.ex b/lib/ash/type/datetime.ex
@@ -38,7 +38,9 @@ defmodule Ash.Type.DateTime do
     storage_type
   end
 
-  def storage_type(_), do: :utc_datetime
+  def storage_type(_constraints) do
+    :utc_datetime
+  end
 
   @impl true
   def generator(_constraints) do

diff --git a/lib/ash/type/type.ex b/lib/ash/type/type.ex
@@ -949,9 +949,12 @@ defmodule Ash.Type do
         def init(opts) do
           constraints = @parent.constraints()
 
+          {:ok, opts} =
+            opts
+            |> Keyword.take(Keyword.keys(constraints))
+            |> @parent.init()
+
           opts
-          |> Keyword.take(Keyword.keys(constraints))
-          |> @parent.init()
         end
 
         @impl true