fix: don't reorder global validations/changes

fix: use latest spark, and new persisters callback
fix: properly validate belongs_to relationships

documentation/dsls/DSL:-Ash.Flow.cheatmd

@@ -921,7 +921,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(module) | module</code>
+    <code class="inline">module | list(module)</code>
   </td>
   <td style="text-align: left">
 
@@ -2470,7 +2470,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(list(atom) | atom)</code>
+    <code class="inline">list(atom | list(atom))</code>
   </td>
   <td style="text-align: left">
 

documentation/dsls/DSL:-Ash.Policy.Authorizer.cheatmd

@@ -1291,7 +1291,7 @@ A field policy that, if passed, will skip all following field policies for that
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -1807,7 +1807,7 @@ for more.
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 

documentation/dsls/DSL:-Ash.Resource.cheatmd

@@ -5235,7 +5235,7 @@ validate changing(:email)
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list((any -> any) | module) | (any -> any) | module</code>
+    <code class="inline">(any -> any) | module | list((any -> any) | module)</code>
   </td>
   <td style="text-align: left">
     <code class="inline">[]</code>
@@ -5915,7 +5915,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -7187,7 +7187,7 @@ validate changing(:email)
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list((any -> any) | module) | (any -> any) | module</code>
+    <code class="inline">(any -> any) | module | list((any -> any) | module)</code>
   </td>
   <td style="text-align: left">
     <code class="inline">[]</code>
@@ -8268,7 +8268,7 @@ validate changing(:email)
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list((any -> any) | module) | (any -> any) | module</code>
+    <code class="inline">(any -> any) | module | list((any -> any) | module)</code>
   </td>
   <td style="text-align: left">
     <code class="inline">[]</code>
@@ -9001,7 +9001,7 @@ define :get_user_by_id, action: :get_by_id, args: [:id], get?: true
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -9458,7 +9458,7 @@ identity :full_name, [:first_name, :last_name]
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -9682,7 +9682,7 @@ change {MyCustomChange, :foo}
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(:create | :update | :destroy) | :create | :update | :destroy</code>
+    <code class="inline">:create | :update | :destroy | list(:create | :update | :destroy)</code>
   </td>
   <td style="text-align: left">
     <code class="inline">[:create, :update]</code>
@@ -9958,7 +9958,7 @@ validate at_least_one_of_present([:first_name, :last_name])
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list((any -> any) | module) | (any -> any) | module</code>
+    <code class="inline">(any -> any) | module | list((any -> any) | module)</code>
   </td>
   <td style="text-align: left">
     <code class="inline">[]</code>
@@ -9979,7 +9979,7 @@ validate at_least_one_of_present([:first_name, :last_name])
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(:create | :update | :destroy) | :create | :update | :destroy</code>
+    <code class="inline">:create | :update | :destroy | list(:create | :update | :destroy)</code>
   </td>
   <td style="text-align: left">
     <code class="inline">[:create, :update]</code>
@@ -10187,7 +10187,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -10492,7 +10492,7 @@ exists :has_ticket, :assigned_tickets
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -10761,7 +10761,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -11068,7 +11068,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -11356,7 +11356,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -11683,7 +11683,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -11970,7 +11970,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -12257,7 +12257,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 
@@ -12546,7 +12546,7 @@ end
 
   </td>
   <td style="text-align: left">
-    <code class="inline">list(atom) | atom</code>
+    <code class="inline">atom | list(atom)</code>
   </td>
   <td style="text-align: left">
 

lib/ash/actions/create/create.ex

@@ -442,8 +442,7 @@ defmodule Ash.Actions.Create do
 
                                   {changeset, _} =
                                     Ash.Actions.ManagedRelationships.validate_required_belongs_to(
-                                      {changeset, []},
-                                      false
+                                      {changeset, []}
                                     )
 
                                   changeset

lib/ash/actions/managed_relationships.ex

@@ -61,29 +61,6 @@ defmodule Ash.Actions.ManagedRelationships do
     end)
   end
 
-  def setup_managed_belongs_to_relationships(%{relationships: relationships} = changeset, _, _)
-      when relationships in [%{}, nil] do
-    {changeset, %{notifications: []}}
-    |> validate_required_belongs_to()
-    |> case do
-      {:error, error} ->
-        {:error, error}
-
-      {changeset, instructions} ->
-        changeset =
-          Map.update!(changeset, :relationships, fn relationships ->
-            Map.new(relationships, fn {rel, inputs} ->
-              {rel,
-               Enum.map(inputs, fn {input, config} ->
-                 {input, Keyword.put(config, :handled?, true)}
-               end)}
-            end)
-          end)
-
-        {changeset, instructions}
-    end
-  end
-
   def setup_managed_belongs_to_relationships(changeset, actor, engine_opts) do
     changeset.relationships
     |> Enum.map(fn {relationship, val} ->
@@ -318,7 +295,7 @@ defmodule Ash.Actions.ManagedRelationships do
             {:halt, {:error, error}}
         end
     end)
-    |> validate_required_belongs_to()
+    |> validate_required_belongs_to(false)
     |> case do
       {:error, error} ->
         {:error, error}

lib/ash/changeset/changeset.ex

@@ -887,6 +887,7 @@ defmodule Ash.Changeset do
   def prepare_changeset_for_action(changeset, action, opts) do
     changeset
     |> Map.put(:action, action)
+    |> reset_arguments()
     |> handle_errors(action.error_handler)
     |> set_actor(opts)
     |> set_authorize(opts)
@@ -895,6 +896,12 @@ defmodule Ash.Changeset do
     |> set_tenant(opts[:tenant] || changeset.tenant || changeset.data.__metadata__[:tenant])
   end
 
+  defp reset_arguments(%{arguments: arguments} = changeset) do
+    Enum.reduce(arguments, changeset, fn {key, value}, changeset ->
+      set_argument(changeset, key, value)
+    end)
+  end
+
   def handle_params(changeset, action, params, handle_params_opts \\ []) do
     if Keyword.get(handle_params_opts, :cast_params?, true) do
       cast_params(changeset, action, params || %{})

lib/ash/resource/dsl.ex

@@ -1314,9 +1314,6 @@ defmodule Ash.Resource.Dsl do
   ]
 
   @transformers [
-    Ash.Resource.Transformers.CacheRelationships,
-    Ash.Resource.Transformers.AttributesByName,
-    Ash.Resource.Transformers.ValidationsAndChangesForType,
     Ash.Resource.Transformers.RequireUniqueActionNames,
     Ash.Resource.Transformers.SetRelationshipSource,
     Ash.Resource.Transformers.BelongsToAttribute,
@@ -1333,6 +1330,12 @@ defmodule Ash.Resource.Dsl do
     Ash.Resource.Transformers.GetByReadActions
   ]
 
+  @persisters [
+    Ash.Resource.Transformers.CacheRelationships,
+    Ash.Resource.Transformers.AttributesByName,
+    Ash.Resource.Transformers.ValidationsAndChangesForType
+  ]
+
   @verifiers [
     Ash.Resource.Verifiers.ValidateRelationshipAttributesMatch,
     Ash.Resource.Verifiers.VerifyReservedCalculationArguments,
@@ -1356,7 +1359,8 @@ defmodule Ash.Resource.Dsl do
   use Spark.Dsl.Extension,
     sections: @sections,
     transformers: @transformers,
-    verifiers: @verifiers
+    verifiers: @verifiers,
+    persisters: @persisters
 
   @doc false
   def identity(x), do: x