fix: emit warnings about already validated actions in before_action h…

…ooks too

lib/ash/changeset/changeset.ex

@@ -328,8 +328,13 @@ defmodule Ash.Changeset do
       quote do
         changeset = unquote(changeset)
 
-        if changeset.__validated_for_action__ && !changeset.context[:private][:in_before_action?] do
-          IO.warn("""
+        {:current_stacktrace, stacktrace} =
+          Process.info(self(), :current_stacktrace)
+
+        if changeset.__validated_for_action__ do
+          require Logger
+
+          Logger.warning("""
           Changeset has already been validated for action #{inspect(changeset.__validated_for_action__)}.
 
           For safety, we prevent any changes after that point because they will bypass validations or other action logic.. To proceed anyway,
@@ -340,15 +345,22 @@ defmodule Ash.Changeset do
             |> Ash.Changeset.new()
             |> Ash.Changeset.#{unquote(function)}(...)
             |> Ash.Changeset.for_create(...)
+
+          #{Exception.format_stacktrace(stacktrace)}
           """)
         end
       end
     else
       quote do
         changeset = unquote(changeset)
 
-        if changeset.__validated_for_action__ && !changeset.context[:private][:in_before_action?] do
-          IO.warn("""
+        {:current_stacktrace, stacktrace} =
+          Process.info(self(), :current_stacktrace)
+
+        if changeset.__validated_for_action__ do
+          require Logger
+
+          Logger.warning("""
           Changeset has already been validated for action #{inspect(changeset.__validated_for_action__)}.
 
           For safety, we prevent any changes using `#{unquote(function)}/#{unquote(arity)}` after that point because they will bypass validations or other action logic.
@@ -358,6 +370,8 @@ defmodule Ash.Changeset do
             |> Ash.Changeset.new()
             |> Ash.Changeset.#{unquote(function)}(...)
             |> Ash.Changeset.for_create(...)
+
+          #{Exception.format_stacktrace(stacktrace)}
           """)
         end
       end
@@ -3918,7 +3932,6 @@ defmodule Ash.Changeset do
   defp run_around_actions(%{around_action: []} = changeset, func) do
     changeset =
       changeset
-      |> put_context(:private, %{in_before_action?: true})
       |> set_phase(:before_action)
 
     result =

lib/ash/query/query.ex

@@ -236,9 +236,13 @@ defmodule Ash.Query do
     quote do
       query = unquote(query)
 
-      if !is_atom(query) && query.__validated_for_action__ &&
-           !query.context[:private][:in_before_action?] do
-        IO.warn("""
+      if !is_atom(query) && query.__validated_for_action__ do
+        {:current_stacktrace, stacktrace} =
+          Process.info(self(), :current_stacktrace)
+
+        require Logger
+
+        Logger.warning("""
         Query has already been validated for action #{inspect(query.__validated_for_action__)}.
 
         For safety, we prevent any changes after that point because they will bypass validations or other action logic.
@@ -248,6 +252,8 @@ defmodule Ash.Query do
           |> Ash.Query.new()
           |> Ash.Query.#{unquote(function)}(...)
           |> Ash.Query.for_read(...)
+
+        #{Exception.format_stacktrace(stacktrace)}
         """)
       end
     end

lib/ash/type/keyword.ex

@@ -192,9 +192,6 @@ defmodule Ash.Type.Keyword do
             {:error, Enum.map(errors, fn error -> Keyword.put(error, :field, field) end)}
         end
 
-      {:error, error} when is_binary(error) ->
-        {:error, [[message: error, field: field]]}
-
       {:error, error} ->
         {:error, [error]}
 

lib/ash/type/map.ex

@@ -171,9 +171,6 @@ defmodule Ash.Type.Map do
             {:error, Enum.map(errors, fn error -> Keyword.put(error, :field, field) end)}
         end
 
-      {:error, error} when is_binary(error) ->
-        {:error, [[message: error, field: field]]}
-
       {:error, error} ->
         {:error, [error]}
 

test/actions/belongs_to_test.exs

@@ -19,7 +19,7 @@ defmodule Ash.Test.Actions.BelongsToTest do
           false ->
             changeset
             |> Ash.Changeset.manage_relationship(:reviewer, nil, type: :append_and_remove)
-            |> Ash.Changeset.change_attribute(:review_by_date, nil)
+            |> Ash.Changeset.force_change_attribute(:review_by_date, nil)
         end
       end)
     end