Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optionally use JSON when available #1689

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

chazwatkins
Copy link
Contributor

@chazwatkins chazwatkins commented Jan 1, 2025

  • Add Ash.Helpers.json_module/0 that uses Elixir's JSON module when loaded. Otherwise it returns Jason. This will enable Jason to be set as an optional dependency in future Ash versions and allow any libraries depending on Ash to leverage the same json_module Ash uses.

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Chaz Watkins added 2 commits December 31, 2024 22:14
- Add `Ash.Helpers.json_module/0` that uses Elixir's `JSON` module when loaded.  Otherwise it returns `Jason`.  This will enable `Jason` to be set as an optional dependency in future Ash versions and allow any libraries depending on Ash to leverage the same `json_module` Ash uses.
@zachdaniel zachdaniel merged commit 088d030 into ash-project:main Jan 1, 2025
31 of 36 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

@chazwatkins chazwatkins deleted the refactor/use_json_module branch January 1, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants