Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for elixir < 1.15 #93

Merged

Conversation

fuelen
Copy link
Contributor

@fuelen fuelen commented May 6, 2024

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

fuelen added 2 commits May 6, 2024 15:56
Warning example:
warning: using map.field notation (without parentheses) to invoke function Spark.Test.Contact.module_info() is deprecated, you must add parentheses instead: remote.function()
  (spark 2.1.20) lib/spark/elixir_sense/plugin.ex:602: Spark.ElixirSense.Plugin.get_suggestions/5
  (spark 2.1.20) lib/spark/elixir_sense/plugin.ex:97: Spark.ElixirSense.Plugin.suggestions/2
  (spark 2.1.20) lib/spark/elixir_sense/plugin.ex:32: Spark.ElixirSense.Plugin.suggestions/4
  (elixir_sense 2.0.0) lib/elixir_sense/providers/suggestion/generic_reducer.ex:43: ElixirSense.Providers.Suggestion.GenericReducer.reduce/6
  (elixir 1.17.0-dev) lib/enum.ex:4858: Enumerable.List.reduce/3
  (elixir 1.17.0-dev) lib/enum.ex:2585: Enum.reduce_while/3
  (elixir_sense 2.0.0) lib/elixir_sense/providers/suggestion.ex:137: ElixirSense.Providers.Suggestion.find/6
  test/elixir_sense/plugin_test.exs:179: Spark.ElixirSense.PluginTest."test entity snippets are correctly shown when parenthesis are involved"/1
  (ex_unit 1.17.0-dev) lib/ex_unit/runner.ex:485: ExUnit.Runner.exec_test/2
@fuelen fuelen changed the title Drop support for old elixir versions Drop support for elixir < 1.15 May 6, 2024
@zachdaniel zachdaniel merged commit 1e656bd into ash-project:main May 6, 2024
14 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants