VK_NV_device_diagnostic_checkpoints: Enable passing pNext-initialized structs to get_queue_checkpoint_data
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
device-diagnostic-checkpoints
branch
from
b04d8b5 to
a05fb7b
Compare
MarijnS95
changed the title
VK_NV_device_diagnostic_checkpoints: Allow passing pNext-initialized structs to get_queue_checkpoint_data
Ralith
approved these changes
Feb 23, 2022
MarijnS95
changed the title
VK_NV_device_diagnostic_checkpoints: Allow passing pNext-initialized structs to get_queue_checkpoint_dataVK_NV_device_diagnostic_checkpoints: Enable passing pNext-initialized structs to get_queue_checkpoint_data
MarijnS95
force-pushed
the
device-diagnostic-checkpoints
branch
from
a05fb7b to
51cba45
Compare
…ucts to `get_queue_checkpoint_data` To match all other functions which accept an array of to-be-initialized structs with a `pNext` pointer that is possibly initialized by the caller.
MarijnS95
force-pushed
the
device-diagnostic-checkpoints
branch
from
51cba45 to
d7ad60c
Compare
MarijnS95
added a commit
that referenced
this pull request
Dec 2, 2024
…`pNext` We've often discussed `pNext` chains in output arrays (i.e. #465, #588, #744), and I always wondered why `read_into_defaulted_vector()` still existed: turns out this helper function was only hiding a few more remaining cases where the caller was previously _not_ able to manually extend the `pNext` chain to request arbitrary more structures to be filled with information. Replace these remaining cases with a separate `_len()` getter, and have the main function take a caller-allocated `&mut [T]` slice where they can initialize the target struct including `pNext` pointer chains.
MarijnS95
added a commit
that referenced
this pull request
Dec 3, 2024
…`pNext` We've often discussed `pNext` chains in output arrays (i.e. #465, #588, #744), and I always wondered why `read_into_defaulted_vector()` still existed: turns out this helper function was only hiding a few more remaining cases where the caller was previously _not_ able to manually extend the `pNext` chain to request arbitrary more structures to be filled with information. Replace these remaining cases with a separate `_len()` getter, and have the main function take a caller-allocated `&mut [T]` slice where they can initialize the target struct including `pNext` pointer chains.
MarijnS95
added a commit
that referenced
this pull request
Dec 4, 2024
…`pNext` We've often discussed `pNext` chains in output arrays (i.e. #465, #588, #744), and I always wondered why `read_into_defaulted_vector()` still existed: turns out this helper function was only hiding a few more remaining cases where the caller was previously _not_ able to manually extend the `pNext` chain to request arbitrary more structures to be filled with information. Replace these remaining cases with a separate `_len()` getter, and have the main function take a caller-allocated `&mut [T]` slice where they can initialize the target struct including `pNext` pointer chains.
MarijnS95
added a commit
that referenced
this pull request
Dec 4, 2024
…`pNext` (#966) We've often discussed `pNext` chains in output arrays (i.e. #465, #588, #744), and I always wondered why `read_into_defaulted_vector()` still existed: turns out this helper function was only hiding a few more remaining cases where the caller was previously _not_ able to manually extend the `pNext` chain to request arbitrary more structures to be filled with information. Replace these remaining cases with a separate `_len()` getter, and have the main function take a caller-allocated `&mut [T]` slice where they can initialize the target struct including `pNext` pointer chains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match all other functions which accept an array of to-be-initialized structs with a
pNextpointer that is possibly initialized by the caller.