Update Vulkan-Headers to 1.3.219

[MarijnS95]

Note that doesn't generate cleanly as vk.xml since 1.3.213 contains an invalid structextends="VkBaseOutStructure"; I removed that locally and it's in the process of being fixed upstream.

[Ralith]

LGTM overall, but do we really want to merge something that breaks CI? Perhaps we could add a temporary hack to the generator?

[MarijnS95]

Wasn't my intent to merge this, sorry for not making that clear. Just PRing it here for visibility (those who'd like to use this and have a supported driver can set up a git reference) and to get started on the API ports.

I'll see how the Khronos issue evolves since there was some thought behind doing this in vk.xml, but it's not at all future-proof. Depending on the pacing I may or may not work around this in the generator, would love to get this in and drop a 0.37.1 release.

[MarijnS95]

Alternatively we have quite a bit of material (8 commits) for a 0.37.1 release; we can publish that now (after merging the Nvidia extension PRs) and go for a 0.37.2 whenever Vulkan .213 is ready with the matching extensions.

[MarijnS95]

It looks like .216 did make some "breaking" changes to VK_EXT_subpass_merge_feedback structs and constants :/

[Ralith]

I don't see any breaking changes compared to master.

[MarijnS95]

See specifically the .216 commit: 03f6b51. Constant names changed, s_type/p_next were removed from RenderPassCreationFeedbackInfoEXT and moved into a new RenderPassCreationFeedbackCreateInfoEXT struct (which has RenderPassCreationFeedbackInfoEXT as member). Exactly the same for RenderPassSubpassFeedbackInfoEXT with a new RenderPassSubpassFeedbackCreateInfoEXT.

[Ralith]

Hmm, wonder how that got through review upstream; not like it's not breaking for C users either. Guess we'd just best hope they had a good reason.

[MarijnS95]

It's an EXT that wasn't/isn't really used yet, so it was decided to just get some const soundness issues over with instead of trying to patch it up in a non-breaking way.

Turns out it's also covered in the .216 changelog commit message:

• Fix the structextends and constness issues in
  apiext:VK_EXT_subpass_merge_feedback (this is a breaking API change, but
  there is only one known implementation at present) (internal issue
  3095).

[MarijnS95]

We managed to fix the issue with a validstructs property: KhronosGroup/Vulkan-Headers@2c823b7#diff-a852a94832433f254f7e5ff6cf889035be373606623d793dfe4a75e535600cbeR12096

While we don't support this properly yet with traits, this compiles and should pass CI now so I'd like to get this and, and I'll make sure to add support to vk-parse and ash before the next release.