extensions/khr: Add VK_KHR_device_group_creation #630
Conversation
| pub fn fp(&self) -> &vk::KhrDeviceGroupCreationFn { | ||
| &self.fp | ||
| } | ||
|
|
||
| pub fn device(&self) -> vk::Instance { | ||
| self.handle | ||
| } |
There was a problem hiding this comment.
We should probably inline these too, since they're utterly trivial.
There was a problem hiding this comment.
We haven't done this for any of ash/src/extensions yet, shall I set that up in a separate PR?
There was a problem hiding this comment.
Sure! IIRC I just didn't have the energy to dig through them all, or maybe my regexes missed them, or something.
There was a problem hiding this comment.
There are many so it's going to take some effort to get this one right. fp()/device()/name() are easy, the rest is just a find-replace on pub unsafe fn I think.
There was a problem hiding this comment.
But again, I'll do that after the remaining extensions (except the ones blocking on the spec update) are merged, so that I won't miss any.
(All the more reason to get a better generator over with sooner than later)
Looks like #630 typo'd the argument for `DeviceGroupCreation::new()` by unnecessarily requiring a move (`Clone`) of `Entry` just to call `get_instance_proc_addr()` on it. Replace this with a borrow to match all other extensions.
No description provided.