extensions/khr/draw_indirect_count: Use the right function pointer for non-indexed draw call #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
MarijnS95
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Nice catch! It has been this way since the extension was introduced in 2020 via #262 (CC @gabdube), and nobody noticed :) (likely because it was stabilized).
Can you document this in the readme?:
diff --git a/Changelog.md b/Changelog.md
index 944fec8..943e6f7 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased] - ReleaseDate
+### Fixed
+
+- extensions/khr/draw_indirect_count: use `cmd_draw_indirect_count_khr` instead of `cmd_draw_indexed_indirect_count_khr` for non-indexed draw call. (#695)
+
### Added
- Update Vulkan-Headers to 1.3.238 (#688)
MarijnS95
changed the title
draw_indirect_countcmd_draw_indirect_count_khr instead of cmd_draw_indexed_indirect_count_khr for non-indexed draw call
MarijnS95
changed the title
cmd_draw_indirect_count_khr instead of cmd_draw_indexed_indirect_count_khr for non-indexed draw call
MarijnS95
changed the title
|
Thanks for the quick review!
Yeah, it seems so, we only noticed because we recently started using the extension exclusively as opposed to either the one in core 1.2 or the ext. |
MarijnS95
reviewed
Dec 21, 2022
|
Ouch, sorry about that |
|
What's the status over here? |
MarijnS95
pushed a commit
that referenced
this pull request
Jan 11, 2023
…r non-indexed draw call (#695)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.