Fix option to enable type analysis (#38)

Option wasn't being passed from cli

Add some end-to-end tests to make sure this option works as expected.

Makefile

@@ -5,6 +5,7 @@ setup:
 
 test:
 	cd examples && diff <(sed 's|CURDIR|$(CURDIR)|' expected_results.txt) <(go run .. 2>&1 | sed '/^go: downloading/d')
+	cd examples && diff <(sed 's|CURDIR|$(CURDIR)|' expected_analyze_types_results.txt) <(go run .. -analyze_types '{p: "^sql\\.DB\\.Exec$$"}' -- 2>&1 | sed '/^go: downloading/d')
 
 lint:
 	pre-commit run --all-files

examples/analyze_types_example.go

@@ -0,0 +1,10 @@
+package examples
+
+import (
+	"database/sql"
+)
+
+func AnaylzeTypesExample() {
+	var db *sql.DB
+	db.Exec("SELECT * FROM users")
+}

examples/expected_analyze_types_results.txt

@@ -0,0 +1 @@
+use of `db.Exec` forbidden by pattern `^sql\.DB\.Exec$` at CURDIR/examples/analyze_types_example.go:9:2

main.go

@@ -16,7 +16,7 @@ func main() {
 	setExitStatus := flag.Bool("set_exit_status", false, "Set exit status to 1 if any issues are found")
 	includeTests := flag.Bool("tests", true, "Include tests")
 	excludeGodocExamples := flag.Bool("exclude_godoc_examples", true, "Exclude code in godoc examples")
-	expand := flag.Bool("analyze_types", false, "Replace the literal source code based on the semantic of the code before matching against patterns")
+	analyzeTypes := flag.Bool("analyze_types", false, "Replace the literal source code based on the semantic of the code before matching against patterns")
 	flag.Parse()
 
 	var patterns = []string(nil)
@@ -35,6 +35,7 @@ func main() {
 	}
 	options := []forbidigo.Option{
 		forbidigo.OptionExcludeGodocExamples(*excludeGodocExamples),
+		forbidigo.OptionAnalyzeTypes(*analyzeTypes),
 	}
 	linter, err := forbidigo.NewLinter(patterns, options...)
 	if err != nil {
@@ -46,7 +47,7 @@ func main() {
 		Tests: *includeTests,
 	}
 
-	if *expand {
+	if *analyzeTypes {
 		cfg.Mode |= packages.NeedTypesInfo | packages.NeedDeps
 	}