Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out all SHP trips #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chaoranxie
Copy link
Contributor

This is not a real PR, more to show code sample.

Hi @ashearer, i am trying to filter out all the trips whose title contains the word SHP. (Spring Hiking Program). The following filter does work, but it only apply to the "All Events by Date" section, i would like to add similar filter on a more global location, any idea? sorry i am not familiar with xsl at all.

I will create a real PR once Boston HB finalized on what we want.

the reasoning behind this is because all program hikes will not be open to non program participants so we want to filter out all of it so people dont even see them.

@chaoranxie chaoranxie marked this pull request as ready for review April 9, 2019 08:01
@chaoranxie
Copy link
Contributor Author

I think I found a "solution" to do what I want by modifying formatListings.inc.php but i am pretty sure that's not the best solution but at least it shows what i want. hope that helps

@ashearer
Copy link
Owner

I haven't had a chance to look at this, but expect to be able to tomorrow night.

I did get a chance to update to the new BostonHB URL, so your trip listings now appear OK again, albeit with the SHP links mixed in. (The web-based version does have some broken HB image links in the header. Please let me know if you're linking that anywhere and would like to update it.)

@chaoranxie
Copy link
Contributor Author

Thanks, yeah, I am not sure if we want the special xsl(with the broken image) just for Boston HB anymore, i kind of just ignore that and want to start new with the default amc-trips-to-html-page.xsl. We are totally still experimenting thus no new PR yet.

You can see different things I have try to fix for HB here,
https://github.com/ashearer/AMC-Trip-Listings/compare/master...chaoranxie:dev?expand=1

The idea is that once we know what we want, I will then create proper PRs to submit back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants