-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare snap shot ignore screen scale #225
Compare snap shot ignore screen scale #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this makes sense, thanks for the PR! I'll get this merged today and released hopefully today/tomorrow 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment apply for all the PR. What do you think?
I'm guessing the CI failure is because the PR was sent from a |
@thanasak-s if you'd like to amend this pull request to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the PR and thanks for your patience! I'll get this merged + released today.
Thanks a lot for contributing @thanasak-s! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions. Generated by 🚫 dangerJS |
Alright, thanks again! This has been released as version |
According to this issue #223