Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare snap shot ignore screen scale #225

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Compare snap shot ignore screen scale #225

merged 3 commits into from
Jun 21, 2021

Conversation

thanasak-s
Copy link
Contributor

According to this issue #223

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes sense, thanks for the PR! I'll get this merged today and released hopefully today/tomorrow 👍

Copy link
Collaborator

@hfehrmann hfehrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment apply for all the PR. What do you think?

Nimble_Snapshots/DynamicSize/DynamicSizeSnapshot.swift Outdated Show resolved Hide resolved
@ashfurrow
Copy link
Owner

ashfurrow commented Jun 10, 2021

I'm guessing the CI failure is because the PR was sent from a branch fork? I'll look into it later.

@ashfurrow
Copy link
Owner

@thanasak-s if you'd like to amend this pull request to use the shouldIgnoreScale then I can run the tests locally and get this merged/deployed 👍

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR and thanks for your patience! I'll get this merged + released today.

@ashfurrow ashfurrow merged commit e2103f3 into ashfurrow:master Jun 21, 2021
@ashfurrow-peril
Copy link

Thanks a lot for contributing @thanasak-s! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Owner

Alright, thanks again! This has been released as version 9.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants