Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Command failed with status 127 (#162) #173

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

NicolasCombe5555
Copy link
Collaborator

Same issue -> #172
Sorry again, not sure why when I test it against my fork it works but when we released 0.29.1 it was not. Anyway I believe 🙏🏻 this will fix it.

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 Ruby is weird, and it's weirdest when it runs on CI.

@ashfurrow ashfurrow merged commit aeafd20 into ashfurrow:master Sep 7, 2021
@ashfurrow
Copy link
Owner

I've released this as 0.29.2, whenever you have a chance to test 👍

@NicolasCombe5555
Copy link
Collaborator Author

NicolasCombe5555 commented Sep 7, 2021

So still an error but this is weird, when running bundle update danger-swiftlint. The script is not inside ~/ext/swiftlint.

Screen Shot 2021-09-07 at 14 19 56

I went to that path and the file is not even there.

Screen Shot 2021-09-07 at 14 22 55

Do we need to do like an extra step here?

@ashfurrow
Copy link
Owner

Wow! Weird, I don't see it in the generated .gem file either.

OH okay I see the problem. The download script is a .sh file, but only .rb files are included in the gemspec. That would explain why it works locally. I'll push a change now to fix 👍

@ashfurrow
Copy link
Owner

That should be fixed here:

0b9223c#diff-c0aa4fa469ac733041252c4ce300c3dbddcbd911efac82f5e0198efd2231e5e1R17

That was released in 0.29.3. Sorry for all the turnaround here!

@NicolasCombe5555
Copy link
Collaborator Author

NicolasCombe5555 commented Sep 7, 2021

It works now 🎉
Screen Shot 2021-09-07 at 14 38 10

Thank you and sorry again 😅

@ashfurrow
Copy link
Owner

Yay! Thanks for verifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants