Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint version to 0.46.2 #176

Merged

Conversation

mvandervelden
Copy link
Collaborator

As the SwiftLint version used by the plugin got outdated, it started introducing discrepancies between our local builds and the report from Danger. (we would fix a warning locally, but it still pops up in Danger because of an older version of the rule).

I think it's warranted to update the swiftlint version as opposed to manually inject the SWIFTLINT_VERSION env var for a version more recent than the plugin.

I'm of course open to suggestions, in case anything else also needs changes to make this work 😅.

@Kaspik
Copy link
Contributor

Kaspik commented Feb 4, 2022

@ashfurrow Pretty please! 🙏🏼

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sounds good. We’ll need to release after merging this, right?

@ashfurrow
Copy link
Owner

(Thank you for the PR, by the way! I’ve been distracted lately so my review times are slower than I’d like, but I always appreciate the work that others contribute 🙏)

@ashfurrow ashfurrow merged commit 00dabeb into ashfurrow:master Feb 4, 2022
@ashfurrow-peril
Copy link

Thanks a lot for contributing @mvandervelden! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@mvandervelden
Copy link
Collaborator Author

Thanks @Kaspik @ashfurrow ! Yes, a release would be awesome 😄

@ashfurrow
Copy link
Owner

Ugh, I'm running into Ruby issues locally. I'll get this released soon 👍

@ashfurrow
Copy link
Owner

Okay, this is released as version 0.30.0. Thanks again!

@aakarsh-sasi
Copy link

aakarsh-sasi commented Feb 16, 2022

@ashfurrow
image
Seems there is an issue with the 0.30.0 release. Was wondering whether a github release is required as well?

@daidongon
Copy link

me too.
#178

@kokluch
Copy link

kokluch commented Feb 17, 2022

as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants