-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SwiftLint version to 0.46.2 #176
Update SwiftLint version to 0.46.2 #176
Conversation
@ashfurrow Pretty please! 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, sounds good. We’ll need to release after merging this, right?
(Thank you for the PR, by the way! I’ve been distracted lately so my review times are slower than I’d like, but I always appreciate the work that others contribute 🙏) |
Thanks a lot for contributing @mvandervelden! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions. Generated by 🚫 dangerJS |
Thanks @Kaspik @ashfurrow ! Yes, a release would be awesome 😄 |
Ugh, I'm running into Ruby issues locally. I'll get this released soon 👍 |
Okay, this is released as version 0.30.0. Thanks again! |
@ashfurrow |
me too. |
as well. |
As the SwiftLint version used by the plugin got outdated, it started introducing discrepancies between our local builds and the report from Danger. (we would fix a warning locally, but it still pops up in Danger because of an older version of the rule).
I think it's warranted to update the swiftlint version as opposed to manually inject the SWIFTLINT_VERSION env var for a version more recent than the plugin.
I'm of course open to suggestions, in case anything else also needs changes to make this work 😅.