Add CLI command to print managed SwiftLint version #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two commands: - version, the plugin version - swiftlint_version, the version of the SwiftLint binary used by the plugin
ashfurrow
reviewed
Mar 14, 2017
| @@ -1,4 +1,4 @@ | |||
| module DangerSwiftlint | |||
| VERSION = "0.16.1".freeze | |||
| VERSION = "0.4.0".freeze | |||
There was a problem hiding this comment.
For anyone else following along, this is fine because 0.16.1 was never released to RubyGems.org so we're fine to "go backward" in semver.
ashfurrow
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://github.com/ashfurrow/danger-swiftlint/issues/31, this PR add a mini CLI to print the version of the managed SwiftLint binary, as well as one printing the plugin version, because why not.
In context with what discussed in the issues it also sets the plugin version to 0.4.0.