When directory is specified, danger-swiftlint is still linting files outside the specified directory #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thii
requested changes
Sep 3, 2017
lib/danger_plugin.rb
Outdated
| @@ -113,6 +115,8 @@ def find_swift_files(files=nil, excluded_paths=[]) | |||
| # Remove dups | |||
| uniq. | |||
| map { |file| File.expand_path(file) }. | |||
| # Ensure only files in the selected directory | |||
| select { |file| file.start_with?(dir_selected)}. | |||
There was a problem hiding this comment.
Shouldn't there be a space before }?
spec/danger_plugin_spec.rb
Outdated
|
|
||
| @swiftlint.lint_files | ||
| end | ||
|
|
There was a problem hiding this comment.
Looks like indents are somewhat incorrect in this chunk.
|
I've addressed the comments @thii :) Do you have permissions to upload the gem? |
thii
approved these changes
Sep 3, 2017
|
@victorg1991 I don't :) |
|
@thii even if I'm using this in danger? |
|
@victorg1991 Yes. Danger plugins are just normal Ruby gems. |
|
@ashfurrow any chance to take a look into this? :) Thanks! |
|
Ah, sorry for the delay. Will look into it now. |
ashfurrow
approved these changes
Sep 8, 2017
|
Cool, this has been released as 0.9.0. Thanks again! |
|
Wow so fast, thank you so much : D |
|
No worries! Feel free to ping me if I ever forget something 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when I run danger-swiftlint with a custom directory and I have also modified files outside this directory, danger-swiftlint is linting all the files.
With this PR danger-swiftlint will only lint the modified files inside the specified directory :)
If this PR gets approved, can you upload a new version of the Gem? Thanks in advance!
Any comment or question would be appreciated