Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle // scheme prefix #75

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Handle // scheme prefix #75

merged 4 commits into from
Oct 29, 2024

Conversation

acrosman
Copy link
Contributor

@acrosman acrosman commented Oct 25, 2024

Fixes #74

During media download, if the scheme is expressed as // replaces with the current URL's scheme before proceeding through the process.

@ashishb
Copy link
Owner

ashishb commented Oct 27, 2024

Thanks for the contribution.
Please point me to some official documentation of /// scheme.

@acrosman
Copy link
Contributor Author

It's commonly known as protocol relative URL, the // are formally knows as a network-path reference : https://datatracker.ietf.org/doc/html/rfc3986#section-4.2

A relative reference that begins with two slash characters is termed
a network-path reference; such references are rarely used. A
relative reference that begins with a single slash character is
termed an absolute-path reference.

My sample file contained a generated link that somehow has three / instead of two, which threw me off. I'll update the text above and PR in a few minutes.

@acrosman acrosman changed the title Handle /// scheme prefix Handle // scheme prefix Oct 27, 2024
@ashishb ashishb merged commit cb78882 into ashishb:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Downloads with /// prefix fail
2 participants