Add Graphlient::Errors::ConnectionFailedError #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially #59 with test. Whenever there is an `Errno::ECONNREFUSED error`, Faraday wraps it in a `Faraday::ConnectionFailed` error. Since it inherits `Faraday::ClientError` without a response (see errors/faraday_server_error.rb), the code would return a `NoMethodError: undefined method []' for nil:NilClass` error. So basically the fix is to rescue `Faraday::ConnectionFailed` before rescuing `Faraday::ClientError` so that we can raise a more meaningful error. Result: ``` Graphlient::Errors::ConnectionFailedError: Failed to open TCP connection to localhost:3000 (Connection refused - connect(2) for "localhost" port 3000) ```
dblock
approved these changes
Nov 13, 2019
| stub_request(:post, url).to_raise(error) | ||
| end | ||
|
|
||
| specify do |
|
Oh one thing. You should add an UPGRADING document in this PR like this one because this does change the interface. If someone was handling the Faraday error they now get a ServerError. |
|
@dblock, I've updated CHANGELOG.md and README.md. Also added UPGRADING.md. Question though, do you want a new section in README.md like https://github.com/dblock/slack-ruby-client#stable-release? |
|
This is perfect, thank you. Feel free to PR something linking to UPGRADING. |
This was referenced Nov 14, 2019
|
thanks @neroleung ! this is awesome! going to cut the release, hopefully before @dblock 😄 |
|
alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially #59 with test.
Whenever there is an
Errno::ECONNREFUSED error, Faraday wraps it in aFaraday::ConnectionFailederror. Since it inheritsFaraday::ClientErrorwithout a response (see errors/faraday_server_error.rb), the code would return aNoMethodError: undefined method []' for nil:NilClasserror.So basically the fix is to rescue
Faraday::ConnectionFailedbefore rescuingFaraday::ClientErrorso that we can raise a more meaningful error.Result: