Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faraday use / adapter error #75

Merged
merged 2 commits into from
May 5, 2020
Merged

Fix faraday use / adapter error #75

merged 2 commits into from
May 5, 2020

Conversation

jfhinchcliffe
Copy link
Contributor

@jfhinchcliffe jfhinchcliffe commented May 2, 2020

References this issue: #73

Faraday has changed so we need to assign an adapter using f.adapter rather than f.use.

As part of this PR, a few tests broke with nested errors etc. I've fixed them / got them all green, however I'm not too familiar with inner exceptions so it's worth a look from someone who knows a bit more than me :)

Will do changelog etc. shortly.

edit

ugh, I'm using Ruby 2.6, and this is 2.3. Having trouble getting Bundler to work with 2.3 :\

@jfhinchcliffe jfhinchcliffe changed the title Fix faraday error Fix faraday use / adapter error May 2, 2020
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like build is failing for good reason.

This change requires a newer version of Faraday, you should change .gemspec to have >= whatever that version it is that introduced adapter vs. use.

CHANGELOG.md Outdated Show resolved Hide resolved
lib/graphlient/errors/timeout_error.rb Outdated Show resolved Hide resolved
@dblock
Copy link
Collaborator

dblock commented May 3, 2020

Please fix the build, see Travis CI output for details.

Add a paragraph to UPGRADING, bump major version.

Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gemspec dependency >= 1.0 is the last thing, thanks for hanging in here.

graphlient.gemspec Outdated Show resolved Hide resolved
UPGRADING.md Outdated

#### Faraday dependency changed to 1.0

See [#75](https://github.com/ashkan18/graphlient/pull/75)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a period at the end.

UPGRADING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gemspec dependency >= 1.0 is the last thing, thanks for hanging in here.

@jfhinchcliffe
Copy link
Contributor Author

jfhinchcliffe commented May 4, 2020

Heya @dblock , all addressed.
Thanks for bearing with me while I fumbled around to get this sorted!
edit: or not sorted. Working on those Travis issues fixed. fixed. I'm a gronk who made a typo.

Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, found one more, sorry :)

CHANGELOG.md Outdated Show resolved Hide resolved
@dblock dblock merged commit 2a9412b into ashkan18:master May 5, 2020
@dblock
Copy link
Collaborator

dblock commented May 5, 2020

👍

@jfhinchcliffe jfhinchcliffe deleted the fix-faraday-use-error branch May 5, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants