Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sync_dist=True when logging best so far validation accuracy #572

Merged
merged 1 commit into from
May 2, 2023

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented May 2, 2023

What does this PR do?

We set sync_dist=True for logging best so far validation accuracy since this metric is logged through value (instead of metric object like all the other metrics in template), so this makes sure it will be synchronized accross devices in multi-gpu setup.

As far as I'm aware, this change doesn't affect the result value of computed metric in this specific case, because synchronization doesn't matter when logging best so far value which is retrieved from other metric object which is already synchronized.

But it's a good practice to indicate this is what should be done when logging trough value.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve ashleve merged commit 334271d into dev May 2, 2023
@ashleve ashleve deleted the fix-sync branch May 2, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant