Set sync_dist=True
when logging best so far validation accuracy
#572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We set
sync_dist=True
for logging best so far validation accuracy since this metric is logged through value (instead of metric object like all the other metrics in template), so this makes sure it will be synchronized accross devices in multi-gpu setup.As far as I'm aware, this change doesn't affect the result value of computed metric in this specific case, because synchronization doesn't matter when logging best so far value which is retrieved from other metric object which is already synchronized.
But it's a good practice to indicate this is what should be done when logging trough value.
Before submitting
pytest
command?pre-commit run -a
command?Did you have fun?
Make sure you had fun coding 🙃