Move to TypeScript #114
Merged
Move to TypeScript #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmind
commented
Mar 16, 2020
WebAssets/ts/connection.ts
Outdated
| } | ||
| for (const handler of handlersByKey) { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| (handler as any)(...handlerArguments); |
There was a problem hiding this comment.
Need to discuss this one.
jsk95
reviewed
Mar 20, 2020
| await Promise.all((await fg(['dist/**/*.js'])).map(async path => { | ||
| const content = await jetpack.readAsync(path); | ||
| const replaced = content.replace(/from '(\.[^']+)';/g, "from '$1.js';"); | ||
| await jetpack.writeAsync(path, replaced); |
There was a problem hiding this comment.
Instead of async await here, why not just return writeAsync promise
There was a problem hiding this comment.
Seems more consistent / easier to follow? Also not much performance difference given it's the build.
WebAssets/tests/editing.tests.ts
Outdated
| @@ -1,8 +1,13 @@ | |||
| const TestDriver = require('./test-driver.js'); | |||
| import { TestDriver } from './test-driver'; | |||
|
|
|||
| // TODO: remove in year 3000 when TC39 finally specs this | |||
There was a problem hiding this comment.
Seems like there was no progress since 2018
WebAssets/tests/hints.tests.ts
Outdated
|
|
||
| // TODO: remove in year 3000 when TC39 finally specs this | ||
| // eslint-disable-next-line no-extend-native | ||
| Array.prototype.last = Array.prototype.last || function() { return this[this.length - 1]; }; | ||
| (Array.prototype as any).last = (Array.prototype as any).last || function<T>(this: Array<T>) { return this[this.length - 1]; }; |
There was a problem hiding this comment.
Why is it here too? Thought I was in a dejavu
There was a problem hiding this comment.
Yep, initial one was one line so it was easier to copy over than reuse in a module.
Tbh probably need to use something like tc39/proposal-array-last#19 (comment) instead for now as there was no progress on last for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial version of the move -- still needs more testing and has few open questions.