Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement X-Super-Client X-Super-Contact Headers #2

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Implement X-Super-Client X-Super-Contact Headers #2

merged 2 commits into from
Apr 30, 2024

Conversation

chatterchats
Copy link
Contributor

fixes #1

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for heckdivers ready!

Name Link
🔨 Latest commit 9222ec5
🔍 Latest deploy log https://app.netlify.com/sites/heckdivers/deploys/66315fc924f6da0008401708
😎 Deploy Preview https://deploy-preview-2--heckdivers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashortsleeves
Copy link
Owner

@chatterchats a few things:

  1. I am an absolute noob when it comes to React and APIs, and I've been using this project to learn both.

  2. I pulled this down locally and checked it out in a preview environment. I'm seeing console errors related to the headers:
    Access to fetch at 'https://api.helldivers2.dev/api/v1/assignments' from origin 'https://deploy-preview-2--heckdivers.netlify.app' has been blocked by CORS policy: Request header field x-super-client is not allowed by Access-Control-Allow-Headers in preflight response.

  3. Thank you so much for contributing, seriously I have no idea what I'm doing, maybe you can help me figure out what is going on. You can checkout the preview environment here https://deploy-preview-2--heckdivers.netlify.app/

@dealloc
Copy link

dealloc commented Apr 30, 2024

that looks like a change on my side, the API needs to tell you you're allowed to send that header basically.
I'm on it :)

@ashortsleeves
Copy link
Owner

Sounds good, I'll merge this once its updated and I'll add the headers here as well.

dealloc added a commit to helldivers-2/api that referenced this pull request Apr 30, 2024
@dealloc
Copy link

dealloc commented Apr 30, 2024

once my PR merges that should roll out automatically, if you could verify things work on your end after the change that'd be great 👍

@chatterchats
Copy link
Contributor Author

Went and made the app.jsx change for ya, help keep the commit history cleaner

@dealloc
Copy link

dealloc commented Apr 30, 2024

as far as I can see things look good for browser clients!
image

@ashortsleeves ashortsleeves merged commit c084ae0 into ashortsleeves:maestro Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement X-Super-Client and X-Super-Contact
3 participants