Make require('iconv-lite') fast #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. I'm wondering what's your use case that you care about 120ms on start? |
|
My script may or may not need to use the iconv-lite library depending on the input. So for every file that I parse that doesn't need it I get a +120ms delay. |
|
Ok, thank you and thanks for the contribution! |
ashtuchkin
added a commit
that referenced
this pull request
May 19, 2013
Implement lazy loading of encodings.
|
Published v0.2.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring iconv-lite is costly due to the library loading the encodings. This fixes that by lazy-loading them.
Before:
After: