Added a recalc two epoch metrics method #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added methods in pipeline.py. - Added vs and m calc methods to utils.py. - Updated docs. - Updated vaex-core version to 4.5.0.
- Changed methods to allow the return of vaex dataframes.
- Minor doc updates (warnings on memory). - Notebook example includes recalculating measurement pairs.
ajstewart
added
documentation
|
Hello @ajstewart! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-07 13:48:36 UTC |
[skip ci]
W503 and W504 contradict each other, W503 is the accepted way. Recommended to disable W504. [skip ci]
[skip ci]
[skip ci]
ddobie
previously approved these changes
Oct 6, 2021
|
Merging with admin privilege as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to the pipeline component to recalculate the two epoch metric pairs dataframe.
I have tested it on the development full pipeline run but sometimes it runs out of memory. So if anyone does ever use it they may run into memory issues on Nimbus if the Hub memory per user is not set high enough.