Fix eta-v matplotlib plot

[ddobie]

Fix #336.

[pep8speaks]

Hello @ddobie! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-06 11:26:28 UTC

[ajstewart]

That was easy, was it something obvious that this was the solution? Has the behaviour of position changed in the subplot declaration?

Need to make sure that notebooks are refreshed before a 3.0 release (I guess there needs to be a general docs go-over as well for that massive PR that was merged).

[ddobie]

That was easy, was it something obvious that this was the solution?

I ran into the same issue when I was re-doing the eta-v plot for the latest GW190814 paper and fixed it on my own branch but for some reason forgot to actually push it. Speaking of which, I also wrote all the code to fix #275, although I think that branch was only on the hub-dev nimbus instance which is now gone.

Has the behaviour of position changed in the subplot declaration?

I never figured out the cause, just the solution. As far as I can tell that behaviour hasn't changed, so my assumption is that something further down the function is overwriting the initial position declaration.

Need to make sure that notebooks are refreshed before a 3.0 release (I guess there needs to be a general docs go-over as well for that massive PR that was merged).

Agreed. I'm pretty sure the docs are actually up to scratch as I was quite thorough when doing that massive PR, but it warrants checking anyway.

Funnily enough I actually noticed an error in the docs this week when using them to provide some example code to a colleague. In https://www.vast-survey.org/vast-tools/notebook-examples/vast-pipeline-example/#performing-transient-and-variable-analysis you mention using df.filter but I believe (based on my knowledge of pandas - I haven't actually checked the vast-tools code) it's actually df.query. I'll try and do a thorough docs check before v3.0.0.

[ajstewart]

Funnily enough I actually noticed an error in the docs this week when using them to provide some example code to a colleague. In https://www.vast-survey.org/vast-tools/notebook-examples/vast-pipeline-example/#performing-transient-and-variable-analysis you mention using df.filter but I believe (based on my knowledge of pandas - I haven't actually checked the vast-tools code) it's actually df.query. I'll try and do a thorough docs check before v3.0.0.

Yep pretty sure that should be query! 😅