Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to RACS data #358

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Fix access to RACS data #358

merged 6 commits into from
Apr 1, 2022

Conversation

ddobie
Copy link
Collaborator

@ddobie ddobie commented Mar 30, 2022

Fix #357.
Fix #359.

@ddobie ddobie marked this pull request as ready for review March 30, 2022 01:22
@ddobie ddobie requested a review from ajstewart March 30, 2022 01:22
@ddobie
Copy link
Collaborator Author

ddobie commented Mar 30, 2022

For what it's worth, this error is missed by the testing because we only test the naming for a single epoch. That should probably be fixed in the future.

@ajstewart
Copy link
Collaborator

For what it's worth, this error is missed by the testing because we only test the naming for a single epoch. That should probably be fixed in the future.

I guess this probably hinges on my point above on whether RACS is needed to be there at this point or not.

ajstewart
ajstewart previously approved these changes Apr 1, 2022
@ddobie ddobie merged commit 06e2e47 into dev Apr 1, 2022
@ddobie ddobie deleted the iss357 branch April 1, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query initialisation: RACS warning is thrown twice. Cannot find RACS images or noise maps
2 participants