Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove epoch 12 user warning #361

Merged
merged 9 commits into from
Apr 4, 2022
Merged

Remove epoch 12 user warning #361

merged 9 commits into from
Apr 4, 2022

Conversation

ddobie
Copy link
Collaborator

@ddobie ddobie commented Mar 30, 2022

Fix #360.

@ddobie ddobie marked this pull request as ready for review March 30, 2022 01:59
@ddobie ddobie requested a review from ajstewart March 30, 2022 04:27
@ajstewart
Copy link
Collaborator

In the docs there are also prominent warnings like this one: https://www.vast-survey.org/vast-tools/components/query/, and is repeated on other pages.

All the per-page warnings could probably be removed now with perhaps just a warning on the data access page in getting started, would you agree?

@ddobie
Copy link
Collaborator Author

ddobie commented Mar 30, 2022

Agreed!

Copy link
Collaborator

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth putting a note about it on the data page or just leave it to the changelog?

I was always uneasy at vast tools containing information about the actual data release as that should be its own thing.

But good to go in any case!

@ddobie
Copy link
Collaborator Author

ddobie commented Apr 4, 2022

Is it worth putting a note about it on the data page or just leave it to the changelog?

I was always uneasy at vast tools containing information about the actual data release as that should be its own thing.

But good to go in any case!

I think it's probably good as-is.

There's a warning in the data access section of the docs that states which version of the data release the package is compatible with (although that's probably outdated now). Maybe it's worth having something more explicit on the introduction page that lists what versions of the data and pipeline the version of tools works with. I'll add that to my to-do list in #352/#354.

@ddobie ddobie merged commit ccb8205 into dev Apr 4, 2022
@ddobie ddobie deleted the iss360 branch April 4, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove epoch 12 warning
2 participants