Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output file naming scheme #403

Merged
merged 20 commits into from
Mar 17, 2023
Merged

Change output file naming scheme #403

merged 20 commits into from
Mar 17, 2023

Conversation

ddobie
Copy link
Collaborator

@ddobie ddobie commented Mar 13, 2023

This pull request changes the naming scheme for output files (.fits, .png, .ann and .reg) to allow multiple files to be saved for each epoch. Files built from pipeline data will be saved in the form SOURCENAME_INDEX.ext, while files built from regular data will be saved in the form SOURCENAME_FIELDNAME_SBID.ext

This also changes the way that various functions inside vastools.source.Source are called, from being called based on epoch to being called based on index, and removing references to epochs in titles.

@ddobie ddobie marked this pull request as ready for review March 13, 2023 05:56
@ddobie ddobie requested a review from ajstewart March 13, 2023 05:56
@ddobie
Copy link
Collaborator Author

ddobie commented Mar 13, 2023

@ajstewart can you take a look at this before I update of the docs etc?

Copy link
Collaborator

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

I don't know the answer but is the find_sources script ok with it? Is there anything there that will break when it attempts to save all the cutouts?

vasttools/source.py Outdated Show resolved Hide resolved
vasttools/source.py Outdated Show resolved Hide resolved
ddobie and others added 2 commits March 14, 2023 08:09
Co-authored-by: Adam Stewart <ajstewart@users.noreply.github.com>
Co-authored-by: Adam Stewart <ajstewart@users.noreply.github.com>
@ddobie
Copy link
Collaborator Author

ddobie commented Mar 13, 2023

It seems to be okay - I've run a few test queries without any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants