Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialise beam centre coords to speed up Fields init #431

Merged
merged 29 commits into from
Jun 6, 2023
Merged

Serialise beam centre coords to speed up Fields init #431

merged 29 commits into from
Jun 6, 2023

Conversation

ddobie
Copy link
Collaborator

@ddobie ddobie commented May 19, 2023 •
edited
Loading

Fix #428.

ddobie added 25 commits May 18, 2023 15:41
@ddobie
Added sc pickle creation, renamed create_fields_csv -> create_fields_…
47b63d2 
…metadata
@ddobie
Added sc pickles for all existing epochs
15ebc23
@ddobie
added zero-padding
ab285bf
@ddobie
Added RACS naming to pickle files
91651b8
@ddobie
Added zero padding
6d5a870
@ddobie
Added zero padding
053adc4
@ddobie
Added _get_resource_path testing
b47d4fa
@ddobie
Added load_fields_skycoords testing
7b6eae6
@ddobie
Load fields scs from pickle
19a974d
@ddobie
Final fixes?
0993ad8
@ddobie
Merge branch 'dev' into store-beam-centre-coords
46e38b2
@ddobie
Fixed docstring
a5b2881
@ddobie
Added docstring
0a87f1f
@ddobie
Fixed zero padding (for now)
58b5060
@ddobie
Added testing - need to fix pickle dump mocking
9c67df1
@ddobie
Fixed testing
b4afada
@ddobie
PEP8
fa6f4a6
@ddobie
More PEP8
6f7d3c8
@ddobie
Added pickle init
3968ff0
@ddobie
Fixed get_resource_path testing
ffc5e95
@ddobie
Pass tests
3fb6115
@ddobie
Added components docs
17c7357
@ddobie
Updates tools.md
7a55e2f
@ddobie
Updated new epoch addition instructions
7e5a2ac
@ddobie
Updated changelog
6d1d960
@ddobie ddobie marked this pull request as ready for review May 19, 2023 06:17
@ddobie ddobie requested a review from ajstewart May 19, 2023 06:17
@ddobie ddobie changed the title Serialise beam centre coords to speed of Fields init Serialise beam centre coords to speed up Fields init May 19, 2023
ajstewart
ajstewart previously approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@ddobie ddobie merged commit 5cec6a7 into dev Jun 6, 2023
@ddobie ddobie deleted the store-beam-centre-coords branch August 25, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajstewart ajstewart ajstewart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store beam centre Skycoord
2 participants
@ddobie @ajstewart