[GB] improve no trades edge case on binance

askmike · Sep 19, 2018 · 2271428 · 2271428
1 parent 28c466d
commit 2271428
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/exchange/wrappers/binance.js b/exchange/wrappers/binance.js
@@ -333,12 +333,17 @@ Trader.prototype.getOrder = function(order, callback) {
 
     const fees = {};
 
+    if(!data.length) {
+      return callback(new Error('Binance did not return any trades'));
+    }
+
     const trades = _.filter(data, t => {
       // note: the API returns a string after creating
       return t.orderId == order;
     });
 
     if(!trades.length) {
+      console.log('cannot find trades!', { order, list: data.map(t => t.orderId) });
       return callback(new Error('Trades not found'));
     }