-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Binance live trading doesn't work #2358
Comments
That function is not supposed to start live trading. Is there an error or a reason why you think live trading is not starting? |
I did now see that this function throws an error when running a paper trader (which is not trading, but simulating). You can get the latest develop version that includes a fix, see here. Let me know if that was the problem you were trying to describe. |
Also have an error at Binance with tradebot. It buys some coins and crashes with the following error:
I'm running 0.6.3 UI |
Switched to develop version, error is different now:
|
@alexandershalin that second error appears to be related to missing dependencies, please run npm install again. As to your initial issue, for me binance trading works fine:
I'll let this trader running for a few hours... @alexandershalin please open a new issue (and include logs found in the logs folder) as I am not sure what problem @francoberton is having, but I doubt it's exactly the same. @francoberton please explain what the exact issue is! |
Now, the issue is fixed with the latest develop version. |
👍 |
* [docs] install indicator libs without updating package.json * add tulip example strat configs, see #2341 * uppercase default macd strat * temp revert bfx dep to main repo (fixes importer) * binance set default fee as percentage * rename bitx to luno (#2352) * v0.6 support for bitx (aka Luno) * v0.6 support for bitx (aka Luno) * remove log * move dependency to gb * rename bitx to luno * rename bitx to luno * make sure we pass amount as positive value * make sure we overlap when importing trades * rm 500 as retryable error, see #2354 * only try to set fee when live trading, see #2358 * make gekko pic path relative * make select arrow path relative * Fix method name for stratNotification event * make sure we parse both TS (backtest) & moment strings (live) * make sure GB throws errors * only render warmup warning when there is required history * v0.6.4 * fix plugin event wire warning * check portfolio data before calculating report (#2369) * Changed several log messages from debug to warn (#2374) Changed "Not creating order" message and "exchange did not provide fee info" from debug to warn messages so users can see these issues even when debug is set to false. * make sure we pass on exchange error (#2379) * fix backtest result exporter in standalone mode (#2382) * make sure to pass order id in cancel edge flow, fix #2386 (#2387) * Emit trade and trade errors via Telegram (#2385) * Emit trade and trade errors via Telegram * Added semi-colons Added missing semi-colons in processTradeCompleted and processTradeErrored methods. * Register methods only if set to true in config * catch undefined CPU cores on ARM (#2391) * export portfolio values as part of stratCandles (#2402) * rm space in backtest export file location * [GB/Binance] retry on 403 (#2404) * completely disable broken limit order for now, fix #2398 * rewire cancelfix cb, see #2386 * remove slack dependency that is triggering warnings (#2408) * move slack plugin dep out of main repo * remove twitter & pushbullet plugin dependencies from main repo (#2409) * move slack dependency out of main repo * rm slack dep from main repo * also remove pushbullet & twitter deps from main repo * use forked bittrex dep with updated dependencies (#2410) * use bittrex fork with updated deps * [GB] introduce optimizedConnection flag in binance * [GB] catch strange networking error * update binance market files, see #2406 * [GB] point to supported_exchanges doc * [GB] add example usage, fix #2414 * assume CF maintainance to be recoverable, fix #2407 * use npm version of of forked bittrex dep * catch gb init errors * [sqlite] wait for 10 seconds on busy * throw errors, not strings * [GB] update bfx & cf markets * Update Luno (#2417) * v0.6 support for bitx (aka Luno) * v0.6 support for bitx (aka Luno) * remove log * move dependency to gb * rename bitx to luno * rename bitx to luno * temp fix simultaneous advice error * - re-add logging - Retry insufficient balance due to server update delay - Enhanced getPorfolio - getOrder now return fees * update * update * update * revert 4b5d09f * v.0.6.5
Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[x] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
The function this.getFee(_.noop) inside binance.js doesn't start live trading with binance
Expected result (what you hoped would happen)
Start binance trading
Actual result (unexpected outcome)
Binance trading fails
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
The text was updated successfully, but these errors were encountered: