Skip to content
This repository has been archived by the owner on Feb 16, 2020. It is now read-only.

some browsers not showing gekko UI (IE 10, OPERA mini Android) #2568

Closed
eusorov opened this issue Sep 28, 2018 · 4 comments
Closed

some browsers not showing gekko UI (IE 10, OPERA mini Android) #2568

eusorov opened this issue Sep 28, 2018 · 4 comments

Comments

@eusorov
Copy link
Contributor

eusorov commented Sep 28, 2018

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.

I'm submitting a ...
[x] bug report
[ ] question about the decisions made in the repository

Action taken (what you did)
start latest version of gekko ui. Open with browser, IE10 or Opera mini on my android. I didnt try with latest IE.

Expected result (what you hoped would happen)
the page with gekko ui is loaded.

Actual result (unexpected outcome)
error in javascript, blank page.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

There is a problem with file: state/reduceState.js
It is excluded in babel.config.js, if it is included, than there is a problem with webpack which can not handle ES6 module and commonjs module. This file is a commonjs module and it will be imported in server:
gekkoManager.js with require ()
At the same time this file is included in client
mutations.js also with require ()

Now some browsers can handle this and some not.
I think to exclude the file from babel transpiler seems also like a hack.

@askmike
Copy link
Owner

askmike commented Sep 29, 2018

I think to exclude the file from babel transpiler seems also like a hack.

Yes this isn't ideal. Note I'm building a new UI. Though still not sure how to work around this:

I've been struggling with how to share javascript code between main gekko (nodejs) and the frontend (babel vue project). In the past I've always used browserify to bundle up (commonjs) nodejs code so it can be used in the frontend. However the babel used my my frontend framework doesn't use commonjs but es 6 export syntax (they are not compatible). While developing the current method I tried to figure out the proper way:

https://stackoverflow.com/questions/51082287/problems-importing-a-shared-script-in-babel-node

But I didn't found many answers.


If anyone can help out to get a better solution? The problem is that I want to have 1 module (that handles gekko update events and merges them into an object) and use that in both the frontend and the backend.

@eusorov
Copy link
Contributor Author

eusorov commented Sep 29, 2018

there are conflicts with dist folder (index.html etc), I will make another branch without dist files.

@askmike
Copy link
Owner

askmike commented Sep 29, 2018

@eusorov awesome that you figured out a better solution! When you submit a PR, can you not fully compile the frontend in that PR? I'm trying to keep the git repo size down, and everytime we recompile the frontend that adds another MB to the repo size. I'm only recompiling now with new full releases.

@stale
Copy link

stale bot commented Nov 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.

@stale stale bot added the wontfix label Nov 28, 2018
@stale stale bot closed this as completed Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants