This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
GDAX cancelOrder fix and misc other fixes #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK all your changes, would you mind reverting all the whitespace changes though? (2 space indents and the likes)? Thanks! |
|
Cleaned up the whitespace a good bit to clarify the changes introduced. |
|
👍 thanks! |
cmroche
reviewed
Jan 30, 2018
| var result = function(err, data) { | ||
| if(err) { | ||
| log.error('Error cancelling order:', err); | ||
| callback(true); // need to catch the specific error but usually an error on cancel means it was filled |
There was a problem hiding this comment.
If you don't return here you will also call callback(false).
There was a problem hiding this comment.
Since it was already merged can you implement this fix?
There was a problem hiding this comment.
I updated my branch with the returns...
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Big Fix / Feature
What is the current behavior? (You can also link to an open issue here)
Same as PR Binance cancelOrder Fix #1806 cancelOrder does not detect filled orders.
What is the new behavior (if this is a feature change)?
Calls to cancelOrder that result in order not found error will presume the order was filled and return true to portfolioManager
Additional minor feature add is to have the ability to enable/disable sandbox using a config value instead of a hard coded boolean in the exchange file itself.
Also same as Binance cancelOrder Fix #1806 I am not 100% this approach is 100% as robust as it could/should be but it works as a stop-gap.
@askmike @cmroche