Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r786218
Browse files Browse the repository at this point in the history
This roll includes:
- https://crrev.com/786119 - mac: close context menu when destroying RenderViewContextMenuMacCocoa

Fixes microsoft#2700
  • Loading branch information
aslushnikov committed Jul 8, 2020
1 parent 8611ee8 commit 3b11878
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 3 deletions.
2 changes: 1 addition & 1 deletion browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"browsers": [
{
"name": "chromium",
"revision": "782078"
"revision": "786218"
},
{
"name": "firefox",
Expand Down
49 changes: 48 additions & 1 deletion src/chromium/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -734,12 +734,25 @@ some CSP errors in the future.
*/
frame: AffectedFrame;
}
export type ContentSecurityPolicyViolationType = "kInlineViolation"|"kEvalViolation"|"kURLViolation"|"kTrustedTypesSinkViolation"|"kTrustedTypesPolicyViolation";
export interface ContentSecurityPolicyIssueDetails {
/**
* The url not included in allowed sources.
*/
blockedURL?: string;
/**
* Specific directive that is violated, causing the CSP issue.
*/
violatedDirective: string;
contentSecurityPolicyViolationType: ContentSecurityPolicyViolationType;
frameAncestor?: AffectedFrame;
}
/**
* A unique identifier for the type of issue. Each type may use one of the
optional fields in InspectorIssueDetails to convey more specific
information about the kind of issue.
*/
export type InspectorIssueCode = "SameSiteCookieIssue"|"MixedContentIssue"|"BlockedByResponseIssue"|"HeavyAdIssue";
export type InspectorIssueCode = "SameSiteCookieIssue"|"MixedContentIssue"|"BlockedByResponseIssue"|"HeavyAdIssue"|"ContentSecurityPolicyIssue";
/**
* This struct holds a list of optional fields with additional information
specific to the kind of issue. When adding a new issue code, please also
Expand All @@ -750,6 +763,7 @@ add a new optional field to this type.
mixedContentIssueDetails?: MixedContentIssueDetails;
blockedByResponseIssueDetails?: BlockedByResponseIssueDetails;
heavyAdIssueDetails?: HeavyAdIssueDetails;
contentSecurityPolicyIssueDetails?: ContentSecurityPolicyIssueDetails;
}
/**
* An inspector issue reported from the back-end.
Expand Down Expand Up @@ -2097,6 +2111,17 @@ instrumentation)
*/
timestamp: number;
}
/**
* Enables/disables rendering of local CSS fonts (enabled by default).
*/
export type setLocalFontsEnabledParameters = {
/**
* Whether rendering of local fonts is enabled.
*/
enabled: boolean;
}
export type setLocalFontsEnabledReturnValue = {
}
}

export module CacheStorage {
Expand Down Expand Up @@ -8018,6 +8043,10 @@ continueInterceptedRequest call.
* Show Negative line number labels (default: false).
*/
showNegativeLineNumbers?: boolean;
/**
* Show area name labels (default: false).
*/
showAreaNames?: boolean;
/**
* The grid container border highlight color (default: transparent).
*/
Expand Down Expand Up @@ -8050,6 +8079,10 @@ continueInterceptedRequest call.
* The column gap hatching fill color (default: transparent).
*/
columnHatchColor?: DOM.RGBA;
/**
* The named grid areas border color (Default: transparent).
*/
areaBorderColor?: DOM.RGBA;
}
/**
* Configuration data for the highlighting of page elements.
Expand Down Expand Up @@ -12148,6 +12181,16 @@ The default is true.
}
export type setUserVerifiedReturnValue = {
}
/**
* Sets whether tests of user presence will succeed immediately (if true) or fail to resolve (if false) for an authenticator.
The default is true.
*/
export type setAutomaticPresenceSimulationParameters = {
authenticatorId: AuthenticatorId;
enabled: boolean;
}
export type setAutomaticPresenceSimulationReturnValue = {
}
}

/**
Expand Down Expand Up @@ -14956,6 +14999,7 @@ unsubscribes current runtime agent from Runtime.bindingCalled notifications.
"CSS.startRuleUsageTracking": CSS.startRuleUsageTrackingParameters;
"CSS.stopRuleUsageTracking": CSS.stopRuleUsageTrackingParameters;
"CSS.takeCoverageDelta": CSS.takeCoverageDeltaParameters;
"CSS.setLocalFontsEnabled": CSS.setLocalFontsEnabledParameters;
"CacheStorage.deleteCache": CacheStorage.deleteCacheParameters;
"CacheStorage.deleteEntry": CacheStorage.deleteEntryParameters;
"CacheStorage.requestCacheNames": CacheStorage.requestCacheNamesParameters;
Expand Down Expand Up @@ -15287,6 +15331,7 @@ unsubscribes current runtime agent from Runtime.bindingCalled notifications.
"WebAuthn.removeCredential": WebAuthn.removeCredentialParameters;
"WebAuthn.clearCredentials": WebAuthn.clearCredentialsParameters;
"WebAuthn.setUserVerified": WebAuthn.setUserVerifiedParameters;
"WebAuthn.setAutomaticPresenceSimulation": WebAuthn.setAutomaticPresenceSimulationParameters;
"Media.enable": Media.enableParameters;
"Media.disable": Media.disableParameters;
"Console.clearMessages": Console.clearMessagesParameters;
Expand Down Expand Up @@ -15437,6 +15482,7 @@ unsubscribes current runtime agent from Runtime.bindingCalled notifications.
"CSS.startRuleUsageTracking": CSS.startRuleUsageTrackingReturnValue;
"CSS.stopRuleUsageTracking": CSS.stopRuleUsageTrackingReturnValue;
"CSS.takeCoverageDelta": CSS.takeCoverageDeltaReturnValue;
"CSS.setLocalFontsEnabled": CSS.setLocalFontsEnabledReturnValue;
"CacheStorage.deleteCache": CacheStorage.deleteCacheReturnValue;
"CacheStorage.deleteEntry": CacheStorage.deleteEntryReturnValue;
"CacheStorage.requestCacheNames": CacheStorage.requestCacheNamesReturnValue;
Expand Down Expand Up @@ -15768,6 +15814,7 @@ unsubscribes current runtime agent from Runtime.bindingCalled notifications.
"WebAuthn.removeCredential": WebAuthn.removeCredentialReturnValue;
"WebAuthn.clearCredentials": WebAuthn.clearCredentialsReturnValue;
"WebAuthn.setUserVerified": WebAuthn.setUserVerifiedReturnValue;
"WebAuthn.setAutomaticPresenceSimulation": WebAuthn.setAutomaticPresenceSimulationReturnValue;
"Media.enable": Media.enableReturnValue;
"Media.disable": Media.disableReturnValue;
"Console.clearMessages": Console.clearMessagesReturnValue;
Expand Down
2 changes: 1 addition & 1 deletion test/headful.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('Headful', function() {
await page.click('button');
await browser.close();
});
it.fail(CHROMIUM && MAC)('should close browser after context menu was triggered', async({browserType, defaultBrowserOptions, server}) => {
it('should close browser after context menu was triggered', async({browserType, defaultBrowserOptions, server}) => {
const browser = await browserType.launch({...defaultBrowserOptions, headless: false });
const page = await browser.newPage();
await page.goto(server.PREFIX + '/grid.html');
Expand Down

0 comments on commit 3b11878

Please sign in to comment.