Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest config to run doctests #55

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

kieran-ryan
Copy link
Collaborator

Present state: as the source code is not configured as a test path, the doc tests do not run locally or in CI.

configfile: pyproject.toml
testpaths: tests
plugins: doctestplus-1.1.0
collected 90 items                                                                   

tests/test_removestar.py ..................................................... [ 58%]
...................................                                            [ 97%]
tests/test_removestar_nb.py ..                                                 [100%]

================================= 90 passed in 7.83s =================================

Change post-configuration:

configfile: pyproject.toml
testpaths: removestar, tests
plugins: doctestplus-1.1.0
collected 93 items                                                                   

removestar/removestar.py s..                                                   [  3%]
tests/test_removestar.py ..................................................... [ 60%]
...................................                                            [ 97%]
tests/test_removestar_nb.py ..                                                 [100%]

=========================== 92 passed, 1 skipped in 6.46s ============================

@kieran-ryan kieran-ryan added bug Something isn't working ci/cd labels Dec 28, 2023
@kieran-ryan kieran-ryan self-assigned this Dec 28, 2023
@kieran-ryan
Copy link
Collaborator Author

kieran-ryan commented Dec 28, 2023

@asmeurer, @Saransh-cpp; any idea what's causing the flakiness in the get_names method doctests, that the order of the return values changes on consecutive runs?

@kieran-ryan kieran-ryan merged commit ed268df into asmeurer:master Dec 29, 2023
7 checks passed
Copy link
Collaborator

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry couldn't take a look sooner, did the flakiness go away?

@kieran-ryan
Copy link
Collaborator Author

kieran-ryan commented Jan 15, 2024

Sorry couldn't take a look sooner, did the flakiness go away?

Remains unresolved, haven't put much time to debug, any ideas? Kept the skip doctest indicator though other doctests now thankfully running in pipeline.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants