Cannot use GetConsoleWindow to test if a console is attached

GetConsoleWindow returns NULL for an invisible console window (e.g. created with CREATE_NO_WINDOW).
asmichi · Jun 29, 2024 · 158017b · 158017b
1 parent 862ef76
commit 158017b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/ChildProcess/Interop/Windows/Kernel32.Console.cs b/src/ChildProcess/Interop/Windows/Kernel32.Console.cs
@@ -7,8 +7,8 @@ namespace Asmichi.Interop.Windows
 {
     internal static partial class Kernel32
     {
-        [DllImport(DllName)]
-        public static extern IntPtr GetConsoleWindow();
+        [DllImport(DllName, SetLastError = true)]
+        public static extern int GetConsoleCP();
 
         [DllImport(DllName, SetLastError = true)]
         public static extern bool GetConsoleMode([In] SafeHandle hConsoleHandle, [Out] out int lpMode);

diff --git a/src/ChildProcess/PlatformAbstraction/Windows/WindowsConsolePal.cs b/src/ChildProcess/PlatformAbstraction/Windows/WindowsConsolePal.cs
@@ -59,6 +59,6 @@ private static bool IsConsoleHandle(SafeFileHandle handle)
             return Kernel32.GetConsoleMode(handle, out var _);
         }
 
-        public bool HasConsoleWindow() => Kernel32.GetConsoleWindow() != IntPtr.Zero;
+        public bool HasConsoleWindow() => Kernel32.GetConsoleCP() != 0;
     }
 }