Add support anisotropic filtering and for limiting the maximum number of mipmaps #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asny
added a commit
that referenced
this pull request
Nov 20, 2024
|
I did it a bit differently in 5a5c1ec, collecting all of the mipmap settings in a separate struct, but otherwise, it's the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limiting the number of mip maps can be useful when dealing with large textures or ones that are updated every frame (e.g. shadow maps) to avoid performance overhead.
Anisotropic filtering requires an extension, however that is pretty much available everywhere and is also supported in WebGL / GL ES contexts.
See also the corresponding changes in
three-dAPIs here: asny/three-d#502