Redo zoom factor implementation + revert adding Planar camera type #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thatcomputerguy0101 I had a change of mind, after testing
three-d
for release, I found that the changes in #40 affected more than I liked and in a very subtle way, so it's very hard for people to update to a new version. Therefore, I redid it in this PR where I'm only scaling the orthogonal camera based on the zoom factor which is again the distance between the camera position and target. Therefore, perspective cameras are not affected and in most cases, orthographic cameras are not either.I also reverted the changes in #42 since I didn't know how to update the zoom function for that camera type. If you want to update that, I can merge it again. However, it also seems to me that it's a very special case and wouldn't be very useful for most people. Is that correct? I also made a trait for the Camera in
three-d
(asny/three-d#514) so now you could implement this camera type outside ofthree-d
if you prefer that.