Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate initial window size #465

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

thatcomputerguy0101
Copy link
Contributor

This separates the initial window size from the max size setting, allowing a window to be created at a smaller size than its maximum. If the initial size is unspecified, it falls back on the max size, maintaining compatibility with existing configurations.

On web, the window is created from the initial size setting (falling back to max size). This may be undesired for most use cases, so a possible modification would be for the web version to ignore the initial size parameter and only use max size. However, applications can work around this by putting a platform macro on the incoming window configuration, so I felt it was likely unnecessary to create that difference in behavior.

@asny
Copy link
Owner

asny commented Aug 23, 2024

Makes sense, thanks for the contribution 🙏

@asny asny merged commit 749b9f8 into asny:master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants