mock! now requires visibility specifiers for inherent methods.
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it forbade them, and treated the inherent method as having the same visibility as the struct itself. That was occasionally problematic, for example when the mock struct was pub but one of its methods' arguments was not. Relates to issue #143
asomers
force-pushed
the
mock_pub_methods2
branch
from
b6e8d73
to
7771459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it forbade them, and treated the inherent method as having
the same visibility as the struct itself. That was occasionally
problematic, for example when the mock struct was pub but one of its
methods' arguments was not.
Relates to issue #143