Fix using QSelf in a where clause or a return type. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In where clauses, this is a regression from 0.7.2. But using qself in return types never worked correctly.
|
The tests are failing because of an update to the syn crate. The failure is already fixed on the r0.8.1 branch. However, I intend to merge this change to the master branch as well. In order to do that without losing merge history, IIUC, the origin of the feature branch must be the most recent common parent of both r0.8.1 and master. So I can't rebase this branch. But I've tested it locally, so I'll merge anyway. |
asomers
added a commit
that referenced
this pull request
Sep 8, 2020
asomers
added a commit
that referenced
this pull request
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In where clauses, this is a regression from 0.7.2. But using qself in
return types never worked correctly.