Support specific impls #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when mock! encountered a trait impl (`impl Foo for Bar`) it would construct a new `Trait` and mock that using the same path used by `#[automock]`. But ever since 0.9.0, it's easier to simply mock the ItemImpl directly. This removes a bunch of internal code, but has no user-visible changes.
Mockall is picker now about how you mock a trait on a generic struct.
Previously you could usually omit the generics. Now, they're required.
i.e.,
```rust
mock!{
MyStruct<T: Bounds> {...}
impl Foo for MyStruct {...}
}
```
should now be written as
```rust
mock!{
MyStruct<T: Bounds> {...}
impl<T: Bounds> Foo for MyStruct<T> {...}
}
```
A specific impl is an implementation of a trait on a generic struct with
specific generic parameters, like `impl Foo for Bar<i32> {}`
Issue #271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specific impl is an implementation of a trait on a generic struct with specific generic parameters, like
impl Foo for Bar<i32> {}Issue #271