Fix nondeterministic code generation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a --cfg reprocheck setting. When enabled, mock! and #[automock] will evaluate every call twice and verify that the output is identical. Also add a test case that is known to currently generate non-reproducible output.
asomers
force-pushed
the
reproducibility
branch
from
503b0b2
to
07693ec
Compare
mockall_derive was internally using HashMap and HashSet and iterating over their contents. But by default those types use random internal state, resulting in nondeterministic output. Switch them to use consistent state. Reported by: David Tolnay @dtolnay
asomers
changed the title
asomers
added a commit
that referenced
this pull request
Sep 10, 2021
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jan 31, 2022
Summary: The mentioned PR asomers/mockall#330 was superceded by asomers/mockall#333 and is part of 0.11 release Reviewed By: dtolnay Differential Revision: D33881560 fbshipit-source-id: 1676f725739939695e4b7b2b8eb14b08ad27e6c1
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Jan 31, 2022
Summary: The mentioned PR asomers/mockall#330 was superceded by asomers/mockall#333 and is part of 0.11 release Reviewed By: dtolnay Differential Revision: D33881560 fbshipit-source-id: 1676f725739939695e4b7b2b8eb14b08ad27e6c1
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jan 31, 2022
Summary: The mentioned PR asomers/mockall#330 was superceded by asomers/mockall#333 and is part of 0.11 release Reviewed By: dtolnay Differential Revision: D33881560 fbshipit-source-id: 1676f725739939695e4b7b2b8eb14b08ad27e6c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mockall_derive was internally using HashMap and HashSet and iterating
over their contents. But by default those types use random internal
state, resulting in nondeterministic output. Switch them to use
consistent state.
Reported by: David Tolnay @dtolnay
Also, add a CI check for nondeterminism. When enabled, mock! and
#[automock] will evaluate every call twice and verify that the output is identical.
Also add a test case that is known to currently generate
non-reproducible output. During CI, build the entire test suite with
this mode enabled.