Always drop static methods' Expectations during Drop #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if a panic is in-progress. Originally we didn't drop them during panic, for fear of double-panicing. But there is already protection from double-panic in Common::drop. Not clearing expectations during a panic can cause surprising failures in one test case after a different test case panics. Fixes #442
|
@DGolubets does this fix your problem? |
|
@asomers Yes, it does. Thanks a lot! |
asomers
added a commit
that referenced
this pull request
Sep 13, 2023
PR #443 ensured that static methods' expectations would be cleared on Drop. But it was only tested for methods that paniced due to too few method calls. For methods with too many calls it actually introduced a double-panic. Double panics are bad; they lead to processes getting SIGABRT. This was a regression in Mockall 0.11.4. Fixes #491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if a panic is in-progress. Originally we didn't drop them during panic, for fear of double-panicing. But there is already protection from double-panic in Common::drop. Not clearing expectations during a panic can cause surprising failures in one test case after a different test case panics.
Fixes #442