Fix return_const for static methods
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) After locking the Mutexes, I wasn't checking them for PoisonErrors 2) Tests that should_panic need to operate on separate methods so they don't poison other tests. 3) The automock_module and automock_foreign_c tests were missing mutex protection
This always should've been there, but was left out due to oversight. The consequence was that return_const couldn't be used with a static method unless it was preceded with a with or withf.
asomers
added a commit
that referenced
this pull request
Jun 6, 2020
This was left out of PR #47 as an oversight. That PR only fixed return_const for non-generic static methods.
asomers
added a commit
that referenced
this pull request
Jun 6, 2020
This was left out of PR #47 as an oversight. That PR only fixed return_const for non-generic static methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
return_constfor static methods