Allow mocking generic methods with lifetime parameters #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping a Fragile<FnMut<...>> in a closure causes problems with HRTBs, because those can't be set using closure syntax
generic methods can now be mocked if they have lifetime parameters or type parameters, but not both.
|
@asomers, that looks like a nicer solution than conditional code compilation! |
|
Thanks for your review, and happy hacking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to mock generic methods with lifetime parameters, as long as they don't also have type parameters, and their return values are
'staticor have the same lifetime asself.@michaelmarconi does this work for you?