Remove default features from predicates dependency #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Hey, this is great! Thanks for noticing. One minor problem, though. Since we reexport predicates, this is technically a breaking change. Therefore, it warrants mention in the CHANGELOG. Could you please add it? Users should be able to fix any breakages by listing predicates, with any required features, in their own Cargo.toml files.
asomers
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predicates has default optional features this crate doesn't use. These features even include regex, which is a heavy dependency. This PR should slightly improve compile times for crates using mockall